Skip to content

[PRM-922] Replace requirements.txt with poetry#1254

Open
NogaNHS wants to merge 10 commits intomainfrom
PRM-922-a
Open

[PRM-922] Replace requirements.txt with poetry#1254
NogaNHS wants to merge 10 commits intomainfrom
PRM-922-a

Conversation

@NogaNHS
Copy link
Copy Markdown
Contributor

@NogaNHS NogaNHS commented May 1, 2026

Overview

Jira ticket: PRM-922

Checklist

Tasks for all changes:

  • 1. I have linked this PR to its Jira ticket.
  • 2. I have run git pre-commits. (WIP)
  • 3. I have added and/or updated relevant tests.
  • 4. I have updated relevant documentation.
  • 5. I have considered the cross-team impact (and have PR approval from both Core & Demographics if necessary).
  • 6. I have successfully deployed this change to a sandbox and witnessed unit, e2e and smoke tests passing:

@NogaNHS NogaNHS requested review from a team as code owners May 1, 2026 14:29
Comment thread lambdas/ecs/data_collection/Dockerfile Fixed
Comment thread lambdas/ecs/data_collection/Dockerfile Fixed
Comment thread lambdas/ecs/data_collection/Dockerfile Fixed
Comment thread lambdas/ecs/data_collection/Dockerfile Fixed
Comment thread lambdas/ecs/data_collection/Dockerfile Fixed
Comment thread lambdas/ecs/data_collection/Dockerfile Fixed
…gin-export, and enforce hash requirements for dependencies
Comment thread lambdas/ecs/data_collection/Dockerfile Outdated
@@ -1,15 +1,25 @@
FROM python:3.11
FROM python:3.11-slim AS builder
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FROM python:3.11-slim AS builder
FROM python:3.11-slim AS builder
# Update the package list and upgrade all installed system packages
RUN apt-get update && \
apt-get upgrade -y && \
rm -rf /var/lib/apt/lists/*

Comment thread lambdas/ecs/data_collection/Dockerfile Fixed
Comment thread lambdas/ecs/data_collection/Dockerfile Fixed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

Code security issues found

View full details here.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 1, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

RUN pip install -r requirements/layers/requirements_core_lambda_layer.txt
RUN pip install -r requirements/layers/requirements_data_lambda_layer.txt
RUN pip install --no-cache-dir --upgrade pip && \
pip install --no-cache-dir poetry==2.3.4 poetry-plugin-export==1.10.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants