Fix toggle in bl2 stage#382
Open
BenReed161 wants to merge 1 commit into
Open
Conversation
re-order the toggle, configuration and firmware first since we are toggling whilst running in BL2. Add to the BL2 toggle and main-fw toggle a no-poll option to sending the command (we don't want switchtec to poll in bl2 since it could render i2c bus unresponsive in a bl2 toggle). Firmware takes longer to toggle due to image CRC verfication, so we send without polling and give some time for it to finish CRC checks. (usleep) Add switchtec_cmd_nopoll as a alternative to polling ver Add a no-retry function for Gen6 to match previous
BenReed161
force-pushed
the
bl2-fw-toggle-fix
branch
from
38d8242 to
f7387a6
Compare
lsgunth
reviewed
May 21, 2026
| if (ret) | ||
| return ret; | ||
| cmd.toggle_fw = 0; | ||
| usleep(5000000); |
Collaborator
There was a problem hiding this comment.
This sleep is a bit suspect. Should it be there? If so, I think it needs a big comment above it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re-order the toggle, configuration and firmware first since we are
toggling whilst running in BL2. Add to the BL2 toggle and main-fw toggle
a no-poll option to sending the command (we don't want switchtec to poll in bl2 since
it could render i2c bus unresponsive in a bl2 toggle). Firmware takes longer
to toggle due to image CRC verfication, so we send without polling and give some
time for it to finish CRC checks. (usleep)
Add switchtec_cmd_nopoll as a alternative to polling ver
Add a no-retry function for Gen6 to match previous