feat(profile-sync-controller): add profile pairing & canonical profile id management#8504
Open
mathieuartu wants to merge 9 commits intomainfrom
Open
feat(profile-sync-controller): add profile pairing & canonical profile id management#8504mathieuartu wants to merge 9 commits intomainfrom
mathieuartu wants to merge 9 commits intomainfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1d56cc0. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Explanation
References
Checklist
Note
Medium Risk
Touches SRP authentication/sign-in flow by adding a new profile-pairing API call and new profile ID semantics, which could affect login/session state and downstream storage key derivation if mishandled.
Overview
Adds SRP profile pairing during
AuthenticationController.performSignIn: when 2+ SRPs are present it callsPOST /profile/pair, propagates the returned canonical profile ID across allsrpSessionDataentries, and emits a newAuthenticationController:profileSignInevent when aliases are returned or the canonical ID changes (pairing failures are treated as non-fatal).Extends auth SDK types and services to support pairing and canonical IDs:
UserProfilegainscanonicalProfileId,ProfileAliasis introduced, SRP/srp/loginnow sendsX-MetaMask-Profile-Pairing: enabledand parsesprofile_aliases, and SRP login resolves/stores the original per-SRPprofileIdfrom aliases via newcomputeIdentifierIdhashing utility.Updates fixtures/mocks and expands unit tests to cover pairing behavior, event emission, header usage, alias parsing, and canonical/original profile ID persistence.
Reviewed by Cursor Bugbot for commit eb46ce4. Bugbot is set up for automated code reviews on this repo. Configure here.