update ownership on geolocation controller package to mobile platform#8496
update ownership on geolocation controller package to mobile platform#8496
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 742501c. Configure here.
|
|
||
| ## Mobile Platform Team | ||
| /packages/app-metadata-controller @MetaMask/mobile-platform | ||
| /packages/geolocation-controller @MetaMask/mobile-platform |
There was a problem hiding this comment.
teams.json not updated for ownership transfer
Medium Severity
The CODEOWNERS file explicitly states to keep it synchronized with teams.json (line 4). The main CODEOWNERS section now assigns geolocation-controller to @MetaMask/mobile-platform, but teams.json still maps "metamask/geolocation-controller" to "team-core-platform". This inconsistency means automated workflows using teams.json will still route issues to the wrong team.
Reviewed by Cursor Bugbot for commit 742501c. Configure here.
There was a problem hiding this comment.
Good point. teams.json is used within the workflow that automatically creates tickets when new major versions of packages are released. Can you update that file as well?
| /packages/build-utils @MetaMask/core-platform | ||
| /packages/composable-controller @MetaMask/core-platform | ||
| /packages/connectivity-controller @MetaMask/core-platform | ||
| /packages/geolocation-controller @MetaMask/core-platform |
There was a problem hiding this comment.
Package release CODEOWNERS entries not updated for new owner
Medium Severity
The "Package Release related" section still assigns geolocation-controller/package.json and CHANGELOG.md ownership solely to @MetaMask/core-platform. Other mobile-platform packages (like app-metadata-controller) include @MetaMask/mobile-platform in these entries. The new owning team won't be required reviewers for release-related file changes.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 742501c. Configure here.
There was a problem hiding this comment.
This is true. We do still need entries for package.json and CHANGELOG.md but we should make sure that your team is included in these entries otherwise they will only be assigned to our team (when GitHub reads lines in the CODEOWNERS file, later lines can override previous lines).


Explanation
Update code ownership of geolocation-controller to mobile platform.
References
Checklist
Note
Low Risk
CODEOWNERS-only change that affects review routing but does not modify runtime code or behavior.
Overview
Updates
.github/CODEOWNERSso/packages/geolocation-controlleris owned by@MetaMask/mobile-platforminstead of@MetaMask/core-platform, shifting review responsibility for that package.Reviewed by Cursor Bugbot for commit 742501c. Bugbot is set up for automated code reviews on this repo. Configure here.