fix(transaction-pay-controller): allow Across perps ETH gas top-up quotes#8493
Open
pedronfigueiredo wants to merge 1 commit intomainfrom
Open
fix(transaction-pay-controller): allow Across perps ETH gas top-up quotes#8493pedronfigueiredo wants to merge 1 commit intomainfrom
pedronfigueiredo wants to merge 1 commit intomainfrom
Conversation
…otes Across perps deposits originating from the PerpsController were being rejected before any quote call when the route included both the USDC deposit leg and the destination-chain ETH gas top-up leg. The existing Across perps support check only allowed the Arbitrum USDC leg, so the ETH leg triggered quotes-strategy-unsupported and the whole route was rejected locally before reaching Across. Widen the perps support gate to allow the native ETH top-up leg while still only normalizing the USDC leg into the HyperCore direct-deposit path. This preserves mixed USDC + ETH perps bundles and adds regression coverage for that route shape.
3f95738 to
eca412d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Across perps deposits originating from the PerpsController were being rejected before any quote call when the route included both the USDC deposit leg and the destination-chain ETH gas top-up leg.
The existing Across perps support check only allowed the Arbitrum USDC leg, so the ETH leg triggered quotes-strategy-unsupported and the whole route was rejected locally before reaching Across.
Widen the perps support gate to allow the native ETH top-up leg while still only normalizing the USDC leg into the HyperCore direct-deposit path. This preserves mixed USDC + ETH perps bundles and adds regression coverage for that route shape.
References
Checklist
Note
Low Risk
Small, well-scoped gating change limited to
perpsDepositquotes on Arbitrum plus new unit coverage; minimal impact outside this route shape.Overview
Enables Across perps deposit quote bundles on Arbitrum to include an additional native-token (ETH) gas top-up leg without being rejected as unsupported.
Updates
isSupportedAcrossPerpsDepositRequestto accept either the Arbitrum USDC direct-deposit leg or the Arbitrum native-token leg, whilenormalizeAcrossRequestcontinues to normalize only the USDC leg to the HyperCore USDC-PERPS route. Adds regression tests for both legs and records the fix in theCHANGELOG.Reviewed by Cursor Bugbot for commit eca412d. Bugbot is set up for automated code reviews on this repo. Configure here.