Skip to content

fix(transaction-pay-controller): poll Across status by deposit txn ref#8489

Open
pedronfigueiredo wants to merge 1 commit intomainfrom
pnf/fix-across-status-poll-deposit-txn-ref
Open

fix(transaction-pay-controller): poll Across status by deposit txn ref#8489
pedronfigueiredo wants to merge 1 commit intomainfrom
pnf/fix-across-status-poll-deposit-txn-ref

Conversation

@pedronfigueiredo
Copy link
Copy Markdown
Contributor

@pedronfigueiredo pedronfigueiredo commented Apr 16, 2026

Explanation

Fix Across deposit status polling to query /deposit/status with depositTxnRef= instead of misusing the quote id as depositId.

Also handle fillTxnRef in the response so the status poller can return the fill transaction reference when Across provides it.

This resolves the repeated 400s seen after the source-chain tx finalized by aligning the request and response handling with Across' current status API shape.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Changes the bridge completion polling request/response logic, which can affect whether intents resolve to the correct destination transaction hash; scope is small and covered by updated unit tests.

Overview
Fixes Across completion polling by querying /deposit/status with depositTxnRef=<source tx hash> (instead of passing quote/deposit id params), aligning with Across’ current status API.

Updates the status response handling to prefer fillTxnRef when returning the destination/fill transaction reference (falling back to destinationTxHash, fillTxHash, txHash, then the source hash), with tests and changelog updated accordingly.

Reviewed by Cursor Bugbot for commit fe98acc. Bugbot is set up for automated code reviews on this repo. Configure here.

@pedronfigueiredo pedronfigueiredo self-assigned this Apr 16, 2026
@pedronfigueiredo pedronfigueiredo requested a review from a team as a code owner April 16, 2026 13:34
@pedronfigueiredo pedronfigueiredo force-pushed the pnf/fix-across-status-poll-deposit-txn-ref branch from 136908d to eda47ab Compare April 16, 2026 13:35
Fix Across deposit status polling to query /deposit/status with depositTxnRef=<source tx hash> instead of misusing the quote id as depositId.

Also handle fillTxnRef in the response so the status poller can return the fill transaction reference when Across provides it.

This resolves the repeated 400s seen after the source-chain tx finalized by aligning the request and response handling with Across' current status API shape.
@pedronfigueiredo pedronfigueiredo force-pushed the pnf/fix-across-status-poll-deposit-txn-ref branch from eda47ab to fe98acc Compare April 16, 2026 13:43
@pedronfigueiredo pedronfigueiredo requested a review from a team as a code owner April 16, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant