Skip to content

Fixed delete button#4513

Open
gabriel-bolbotina wants to merge 1 commit into
masterfrom
fix-photo-delete-button
Open

Fixed delete button#4513
gabriel-bolbotina wants to merge 1 commit into
masterfrom
fix-photo-delete-button

Conversation

@gabriel-bolbotina
Copy link
Copy Markdown
Contributor

Added check if the sketching controller is available or not, which fixes:

  • the broken delete button when photo sketching is not selected
  • reappearing sketches when deleting a photo with sketches and re-adding it in the project.

UI changes:

https://github.com/user-attachments/assets/3b4772aa-a900-49e5-a2b7-21317ec761e1
https://github.com/user-attachments/assets/28724eb1-1c9f-4498-bcd1-f333ad2adac7

@github-actions
Copy link
Copy Markdown

Coverage Report for CI Build 26298805232

Coverage remained the same at 57.914%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 15233
Covered Lines: 8822
Line Coverage: 57.91%
Coverage Strength: 100.55 hits per line

💛 - Coveralls

@github-actions
Copy link
Copy Markdown

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 68651 dmg Expires: 20/08/2026 #6865
linux Build 📬 Mergin Maps 68851 x86_64 Expires: 20/08/2026 #6885
win64 Build 📬 Mergin Maps 60591 win64 Expires: 20/08/2026 #6059
Android Build 📬 Mergin Maps 817511 APK [armeabi-v7a] Expires: 20/08/2026 #8175
📬 Mergin Maps 817511 APK [armeabi-v7a] Google Play Store #8175
Android Build 📬 Mergin Maps 817551 APK [arm64-v8a] Expires: 20/08/2026 #8175
📬 Mergin Maps 817551 APK [arm64-v8a] Google Play Store #8175
iOS Build Build failed or not found. #9117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant