Paginationv2#78
Open
jimmyli97 wants to merge 354 commits intoMaRDI4NFDI:masterfrom
Open
Conversation
Easier to read/modify later Added SuppressWarnings
renamed latexhelper to extracthelper extracthelper transitioning to use jsoup skeletons for extracthelper.extractmath, wikimapper, wikiquerymapper mml and pmml fields for WikiTuple and wikiQueryTuple reorganization into /java folders
constructed wikiquery integration test commented out main task tests in pom (focusing on wiki tasks)
Covers all entity references for HTML 4.01 Switch from document back to string in tuples (documents unserializable) Bugfixes in ExtractHelper
eclipse build path errors added fault tolerance to querymapper writing test case for querymapper only
Now runs integration tests correctly Added fault tolerance for NPE (though this should not occur, currently looking at it)
Added static init to extracthelper to init canonicalizer configuration Changed extracthelper's canonicalizer method to throw exceptions Added low level debugging to wikiquerymapper
Uses new configuration file Handles entities properly.
Entities are left unescaped Got rid of debugging logs QueryMapper now ignore annotation tag for PMML
WikiMapper code complete Code cleanup for WikiQueryMapper Clarified test name
fix directory/file lookup errors as well
Added dependency in pom for future configuration @ignore used to select tests
* Resolves MaRDI4NFDI#63 * BaseX server always uses "admin" "admin" for log in, different from RestX password. User/password is only set in Client, so moved the fields to Client and forced "admin" "admin" as log in * Update Server command line arguments to include hostname
* Add testCheckHealth() unit test * Remove static import * Formatting
* Check if connection is stable before running unit tests * See MaRDI4NFDI#67 * Upgrade to HttpClient v 4.5 * Remove old dependency on HttpClient Commons
* Separate nested classes into different classes to make it easier to serialize into XML later * Remove csv option (added todo to add in moritz' translation xslt later * Added showTime methods to Run and Result to separate the classes (this will be refactored later into a global variable during xml serialization)
* Made Results into five classes, all marshallable and unmarshallable by XStream * Added unit tests for marshalling/unmarshalling * Minor changes to XML format: * Total attribute is removed from <results> (not part of NTCIR format) (Client) * Escaped html characters inside attribute values in BasicTest (Client) * Removed xmlns from <hit> (not part of NTCIR) * Added <run> tag in between <results> and <result> (part of NTCIR) * All tags self close when they have no children (resolves MaRDI4NFDI#64) * Removed new line after </results> Resolves MaRDI4NFDI#57
Refactor results client3
Null assignment is the only thing needed to make the attribute disappear
* Make TexQueryGenerator and Client throw exceptions to indicate errors rather than returning a string with the error message. This makes it much easier to tell when something went wrong. * Make Client functions return Results and Result objects rather than an XML string. This makes it much easier to manipulate the objects for later functionality (such as pagination) * As above, make MathRequest store Results objects. Resolves MaRDI4NFDI#68
Refactor exception handling and Client output
Uses autostartable component to make a cache that persists through requests but is destroyed on server exit.
* Caches last 30 results * Cache is flushable
This will make pagination much easier, at the cost of security.
Ensures cache will not be mistakenly modified Allows for cloning through constructor (e.g. new Result( result )) Make getters consistent in returning strings
* Accept queries and Results rather than MathRequests, and log cloned MathRequests using a clone constructor to make sure that the cache MathRequests cannot be modified * Initialize fields outside of start() so that the Cache can be used outside of restx
* Process options specifying queryID, runtype, limit, and offset
* Uses queryID and runtype to narrow results * Uses limit/offset to paginate Resolves MaRDI4NFDI#49
jimmyli97
force-pushed
the
paginationv2
branch
from
c79e2f1 to
94829ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does not fully fix #49 because it does not parse the mws data