Remove whitespace in Makefile#984
Closed
stephenmsachs wants to merge 1 commit intoMPAS-Dev:hotfix-v7.4from
Closed
Conversation
This seems trivial but I have actually written an sed parser that trips over this here: https://github.com/spack/spack/blob/43673fee808f9e02efcb4330c6a7fa2c9b80c14c/var/spack/repos/builtin/packages/mpas-model/package.py#L74
Contributor
|
@stephenmsachs Thanks for opening this PR. The change looks good to me, of course. One small request, though: could you update the commit message and PR description to describe in a sentence or two what the change accomplishes without referencing a link that may disappear in future? Something to the effect of "Remove a space on an otherwise blank line separating two build targets in the top-level Makefile for consistency."? If you don't mind, I can also just force-push an update to your branch. |
Author
|
Closing in favor of #987 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems trivial but I have actually written an sed parser that trips over
this here:
https://github.com/spack/spack/blob/43673fee808f9e02efcb4330c6a7fa2c9b80c14c/var/spack/repos/builtin/packages/mpas-model/package.py#L74