Fix top navbar border when using other materials#96
Open
FantomTchi7 wants to merge 1 commit intoLockframe:mainfrom
Open
Fix top navbar border when using other materials#96FantomTchi7 wants to merge 1 commit intoLockframe:mainfrom
FantomTchi7 wants to merge 1 commit intoLockframe:mainfrom
Conversation
Owner
|
Thank you for making the pull request, but your modifications not only ensured there is a 1px vertical border behind the active tab in light mode regardless of the backdrop being used, it also removed the navbar's upper border entirely, which is a regression in terms of following WinUI's design guidelines. 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #95