Add Unexpected Treasure quest implementation#10071
Open
Lydya-nick77 wants to merge 1 commit into
Open
Conversation
Lydya-nick77
force-pushed
the
unexpected-treasure-quest
branch
from
242387f to
c77281b
Compare
Lydya-nick77
force-pushed
the
unexpected-treasure-quest
branch
from
f24c3cd to
cb15193
Compare
Xaver-DaRed
reviewed
May 20, 2026
|
|
||
| [637] = function(player, csid, option, npc) | ||
| -- Calovour explains she needs a Sprig of Mistletoe; no state change needed. | ||
| end, |
Contributor
There was a problem hiding this comment.
Unneeded onEventFinish. It does nothing
Xaver-DaRed
reviewed
May 20, 2026
| elseif prog == 1 then | ||
| return quest:progressEvent(636) | ||
| else | ||
| return quest:event(636) |
Contributor
There was a problem hiding this comment.
?
Why is the same event called twice? And if this is the actual behavior, why different steps. just else it
Xaver-DaRed
reviewed
May 20, 2026
|
|
||
| [636] = function(player, csid, option, npc) | ||
| quest:setVar(player, 'Prog', 2) | ||
| end, |
Contributor
There was a problem hiding this comment.
And continuing my previous comment, you should check for the var == 1 or else you will de-progress the quest on accident.
Contributor
|
Why is this quest coded in a completely different manner than most quests? |
| onEventFinish = | ||
| { | ||
| [30003] = function(player, csid, option, npc) | ||
| quest:setLocalVar(player, 'questSeen', 1) |
Contributor
There was a problem hiding this comment.
What is the questSeen var for?
If the quest is accepted it won't be available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Adds the missing quest Unexpected Treasure in San d'Oria by adding the file scripts/quests/sandoria/Unexpected_Treasure.lua
Steps to test these changes
Purchase a Cupboard from Justi at the furniture shop in (F-8) and put it in your mog house.
Zone out and back into your mog house.
Wait some time (1 real-world minutes).
Talk to your Moogle. He will say he found something, and give you a Key Item Small teacup.
Return to the furniture shop and speak to Morunaude twice.
Speak to Calovour in the Cathedral (M-6).
Trade Calovour a Mistletoe to complete the quest.