Disable dropped-audio submit check by default#168
Merged
mfwolffe merged 1 commit intoLab-Lab-Lab:mainfrom Apr 10, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enableDroppedAudioDetectionWhy
Normal student recording submits were still invoking the dropped-audio scan and could be blocked by the warning flow. This change keeps the feature available without firing during the regular activity submit path.
Opt in
If we still want pre-submit dropped-audio scanning in a specific flow, render the recorder with:
<Recorder enableDroppedAudioDetection />That re-enables the existing
catchSilence(...)pre-submit check and warning modal for that recorder instance.