feat(hud): breathing buddy face states (Wave 2-A)#1481
Closed
JeremyDev87 wants to merge 2 commits into
Closed
Conversation
The Buddy face now reacts to HUD phase / blocker state so the status bar feels alive: Idle / Ready -> ◕‿◕ (FACE_IDLE) Thinking / Planning-> ◔‿◔ (FACE_THINKING) Active / Executing -> ◕◡◕ (FACE_ACTIVE) Error / Blocked -> ◕︵◕ (FACE_ERROR) Victory / Completed-> ◕ᴗ◕ (FACE_VICTORY) Priority resolution: 1. blocker_count > 0 always wins (error face) 2. recent_event == "victory" beats phase 3. Phase lookup (case-insensitive) 4. Fallback to FACE_IDLE hud_buddy.py extended: - FACE_* constants for each state - _PHASE_FACE_MAP for phase -> glyph lookup - get_buddy_face(phase, *, blocker_count, recent_event) pure function - select_face_from_state(hud_state) convenience dict wrapper - __all__ exports updated BUDDY_FACE is still canonically re-exported from tiny_actor_presets (identity lock preserved). 29 new tests in test_hud_buddy.py cover: - All 5 face constants distinct + non-empty - All 6 phase mappings (ready/planning/executing/evaluating/cycling/completed) - Case-insensitive phase, unknown phase, empty, None - Priority: blocker beats phase, blocker beats victory - Malformed blocker_count fall-through - Victory event recognition (case-insensitive) + unknown event - select_face_from_state (empty, None, planning, blocked, victory) - __all__ public API coverage 158/158 pass. Part of #1464 (Wave 0 statusbar refactor)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeremyDev87
force-pushed
the
feat/statusbar-wow-buddy
branch
from
aff69b1 to
2b87537
Compare
JeremyDev87
added
area:hud
JeremyDev87
force-pushed
the
feat/statusbar-wow-refactor
branch
from
7b89e0b to
11c38dd
Compare
Combined Wave 0 polish items from the #1465/#1485 review cycle: 1. Narrow `except Exception` to `except ImportError` in the 3 lib fallback import blocks (qual-1465 HIGH-1). Real logic bugs (SyntaxError, NameError, AttributeError) inside lib modules now surface immediately instead of being silently swallowed by a catch-all. 2. Drop inline stub functions for format_rate_limits and _get_fresh_version (qual-1465 HIGH-2). Eliminates the signature drift between canonical lib definitions and in-file fallback stubs observed on the integrator branch (Wave 1-A plugin_json_file kwarg drift). The outer main() try/except still catches any runtime failure and emits the minimal safe output via the BUDDY_FACE constant. 3. Hoist hud_velocity and hud_cache_savings imports to module top as _format_velocity_segment and _format_cache_savings (perf-1485 H1). Eliminates ~0.47us sys.modules lookup per render. Integrator branch only - no-op on refactor/wave branches where the inline imports don't exist yet. 4. Bump next to 16.2.3 for GHSA-q4gf-8mx6-v5v3 (landing-security-check). Aligns eslint-config-next and updates setup.test.ts assertion. Refs: qual-1465 HIGH-1/2, perf-1485 H1, GHSA-q4gf-8mx6-v5v3
JeremyDev87
force-pushed
the
feat/statusbar-wow-buddy
branch
from
2b87537 to
febc0d8
Compare
JeremyDev87
added
statusbar-wave:2
Owner
Author
Superseded by #1485This PR was part of a stacked PR structure ( All of this PR's commits have been consolidated into #1485 (now with
EVAL review results from this PR (all reviewers, iter1 converged → Critical=0, High=0) already applied in #1485. Closing as superseded. Use #1485 with GitHub's Rebase and merge button to land all 12 commits linearly on master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the buddy face issue. Stacked on #1465. 29 new tests. 158/158 pass. Buddy identity re-export preserved.