fix: reduce thread contention in DC TableLoader#1238
Open
baltzell wants to merge 2 commits intodevelopmentfrom
Open
fix: reduce thread contention in DC TableLoader#1238baltzell wants to merge 2 commits intodevelopmentfrom
baltzell wants to merge 2 commits intodevelopmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unnecessary/ineffective synchronize locks and privatize methods.
The first 3 modified methods are only called once per event and only by the public, synchronized method
TableLoader.Fill(IndexedTable ...). Since their sole caller is also synchronized, removing their ownsynchronizeddoesn't have any affect on thread contention or safety, just removes unnecessary locking. We can also make them private to help avoid confusion and misuse.But the last 2,
calc_TimeandgetDeltaTimeBeta, are called externally, later in each event, and maybe many times per event. Note, their locking isn't useful and does nothing to prevent the underlying data from changing during access or even since initialization; it only prevents multiple threads from calling the same reader method simultaneously.