Skip to content

Add k type check to triu_indices#2855

Merged
antonwolfy merged 7 commits intomasterfrom
add-k-type-check-to-triu_indices
Apr 22, 2026
Merged

Add k type check to triu_indices#2855
antonwolfy merged 7 commits intomasterfrom
add-k-type-check-to-triu_indices

Conversation

@antonwolfy
Copy link
Copy Markdown
Contributor

@antonwolfy antonwolfy commented Apr 15, 2026

The PR adds explicit type check to k keyword in dpnp.triu_indices function.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy added this to the 0.20.0 release milestone Apr 15, 2026
@antonwolfy antonwolfy self-assigned this Apr 15, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Apr 21, 2026

Coverage Status

coverage: 78.429% (-0.002%) from 78.431% — add-k-type-check-to-triu_indices into master

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026

Array API standard conformance tests for dpnp=0.20.0dev6=py313h509198e_22 ran successfully.
Passed: 1357
Failed: 3
Skipped: 16

@antonwolfy antonwolfy marked this pull request as ready for review April 21, 2026 16:57
Copy link
Copy Markdown
Contributor

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit 26383d1 into master Apr 22, 2026
73 of 78 checks passed
@antonwolfy antonwolfy deleted the add-k-type-check-to-triu_indices branch April 22, 2026 12:50
github-actions Bot added a commit that referenced this pull request Apr 22, 2026
The PR adds explicit type check to `k` keyword in `dpnp.triu_indices`
function. 26383d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants