Fix matrix_rank for empty matrices#2853
Merged
antonwolfy merged 8 commits intomasterfrom Apr 22, 2026
Merged
Conversation
Collaborator
|
coverage: 78.431% (+0.002%) from 78.429% — matrix-rank-for-empty-array into master |
Contributor
|
Array API standard conformance tests for dpnp=0.20.0dev6=py313h509198e_22 ran successfully. |
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
Co-authored-by: vlad-perevezentsev <vladislav.perevezentsev@intel.com>
vlad-perevezentsev
approved these changes
Apr 21, 2026
Contributor
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
There was a problem hiding this comment.
LGTM
Thank you @antonwolfy
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
github-actions Bot
added a commit
that referenced
this pull request
Apr 22, 2026
This PR fixes `dpnp.linalg.matrix_rank` to handle empty matrices (arrays with zero-size dimensions) without raising a `ValueError`. Previously, calling `matrix_rank` on empty arrays would fail: ```python import dpnp as np dpnp.linalg.matrix_rank(np.zeros((0, 0))) # ValueError: reduction cannot be performed over zero-size axes ``` The PR also adds comprehensive tests coverage, including testing both normal and Hermitian modes. 3007bee
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
dpnp.linalg.matrix_rankto handle empty matrices (arrays with zero-size dimensions) without raising aValueError.Previously, calling
matrix_rankon empty arrays would fail:The PR also adds comprehensive tests coverage, including testing both normal and Hermitian modes.