fix: partial write support and default write endpoint#388
Open
alespour wants to merge 10 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #388 +/- ##
==========================================
+ Coverage 88.25% 88.29% +0.04%
==========================================
Files 21 21
Lines 1532 1546 +14
Branches 277 279 +2
==========================================
+ Hits 1352 1365 +13
- Misses 82 83 +1
Partials 98 98 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR restores V2 write endpoint defaults while preserving V3-only partial-write and noSync support behind useV2Api=false.
Changes:
- Defaults write routing to the V2 API endpoint and updates related tests/expectations.
- Refines V2/V3 method-not-allowed error messages and partial-write error formatting.
- Updates README and changelog language around partial writes and endpoint compatibility.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/main/java/com/influxdb/v3/client/write/WriteOptions.java |
Changes default write endpoint selection to V2 and updates validation/docs. |
src/main/java/com/influxdb/v3/client/internal/InfluxDBClientImpl.java |
Adds endpoint-specific 405 guidance for V2 and V3 writes. |
src/main/java/com/influxdb/v3/client/internal/RestClient.java |
Adjusts partial-write detail rendering and fallback JSON token formatting. |
src/main/java/com/influxdb/v3/client/InfluxDBClient.java |
Updates public configuration documentation. |
src/main/java/com/influxdb/v3/client/config/ClientConfig.java |
Updates write endpoint configuration documentation. |
src/test/java/... |
Updates and expands tests for defaults, routing, validation, and error formatting. |
README.md |
Documents default V2 writes and V3-only write options. |
CHANGELOG.md |
Records partial-write support and V2 default behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR finalizes partial-write support and fixes regression issue with the default API endpoint behavior introduced in PR #365.
noSyncacceptPartialChecklist