Skip to content

[FIX] Object 47771: Custom command modals are not available for item groups#11548

Open
lukas-heinrich wants to merge 1 commit into
ILIAS-eLearning:trunkfrom
lukas-heinrich:fix/12/modal-rendering-in-list-item-html
Open

[FIX] Object 47771: Custom command modals are not available for item groups#11548
lukas-heinrich wants to merge 1 commit into
ILIAS-eLearning:trunkfrom
lukas-heinrich:fix/12/modal-rendering-in-list-item-html

Conversation

@lukas-heinrich
Copy link
Copy Markdown
Contributor

Hi everyone,

This PR addresses the issue described in 47771, where modals for custom commands are not rendered in the header of ItemGroup-Lists. In this PR, I propose adding a method for rendering these modals and integrating it into the ItemGroups renderer.

I appreciate any feedback or suggestions.

Best
@lukas-heinrich

@kergomard
Copy link
Copy Markdown
Contributor

Hi @lukas-heinrich

Thanks for the PR @lukas-heinrich , but I don't think this is right. The Custom-Modals are an internal problem of ilObjectListGUI and they should not and I do not want them to be handed out. There are already enough special cases like this. Right now I do not have resources to put into this, so I'm sorry that I'm not able to provide you with more support to find the right solution, my first thought is that this should happen somewhere in a class inheriting from ilObjectListGUI. This pattern is already bad enough, but it seems to be the way this has been built.

Best,
@kergomard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix improvement php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants