News 42549: Public Notifications Cannot Be Activated#11538
Open
aaronbidzan wants to merge 1 commit into
Open
Conversation
See: https://mantis.ilias.de/view.php?id=42549 Internal news were off globally but the public notifications checkbox stayed editable. It is now disabled in that case, with a brief explanation in the info text.
mjansenDatabay
added
the
translations
Member
|
@aaronbidzan Thanks for the PR! @thojou As I am not sure which direction you would like to take here (especially the future role of the container component in this), I am waiting for your feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix https://mantis.ilias.de/view.php?id=42549.
Even though global internal news was turned off, the user could still change the public notifications checkbox, but it would not save. I have now added an info text into the byline and disabled the checkbox in this case.
Kind regards,
@aaronbidzan
/cc @thojou