Spec: Server side ad templates creative-opportunities cli#724
Open
prk-Jr wants to merge 3 commits into
Open
Conversation
Defines the `ts-config` CLI tool for validating, matching, linting, and checking `creative-opportunities.toml` without a Rust toolchain. Also covers the Node.js `ts-config-generate` browser-automation tool for generating slot configs from live publisher pages. Key decisions: - Rust binary for validate/match/lint/check (mirrors runtime glob + slot ID logic) - Node.js/Playwright for generate (browser automation, reuses js-asset-auditor stack) - Phase 1A (Rust) ships independently; Phase 1B (Node.js) waits on feature/js-asset-auditor - Layer 1 init script uses addInitScript function form to scope settle correctly - googletag.cmd.push interception closes race with deferred GPT setup pattern - EmptySlotId variant distinct from InvalidSlotId in ValidateError enum - Concrete test shapes for both Rust unit/integration and Node.js unit/integration
prk-Jr
changed the title
- Align gam_unit_path/div_id with runtime Option<String>: optional but non-empty if present - Expand validate rules from 10 to 11: add missing_leading_slash, empty_gam_unit_path, empty_div_id - Add ValidateError variants for all three new rules - Add fixture matrix rows for new rules (missing-leading-slash, empty-gam-unit-path, empty-div-id) - Add fake-publisher-direct.html fixture for direct defineSlot coverage (Layer 1 patchGoogletag) - Fix Layer 1/2 labelling throughout: direct defineSlot is Layer 1, not Layer 2 - Clarify "match does not validate" as skipping semantic validation after typed load - Define slot ID derivation algorithm: tokenize, filter generics/single-chars/hash fragments, fallback to unitPath - Define generator behaviour when all sizes are unsupported: omit slot, warn to stderr - Add APS correlation tests for size-only and name/size conflict (Step C rules 5 and 7) - Add unit test for short-prefix no-merge (<4 chars) - Update cross-page reconciliation rule 3: prefix must be ≥ 4 chars - Fix /20** invalidity: generator emits /20*, tests updated - Fix APS fetchBids setter recursion: use value descriptor after patching - Fix JSON kind registry: add empty_gam_unit_path and empty_div_id - Fix JSON field-path contract: all examples now use full TOML paths (slots[N].field) - Fix stale rule-count references and "Two/three fixtures" wording - Add --target-dir "$(pwd)/target" to all CLI cargo commands including CI test command - Specify [lints.clippy] for excluded CLI crate (print_stdout allow, print_stderr warn)
| src/match_cmd.rs ← glob matching | ||
| src/report.rs ← output formatting (human + JSON) | ||
|
|
||
| packages/js-asset-auditor/ ← Node.js package (feature/js-asset-auditor branch) |
Collaborator
There was a problem hiding this comment.
the claude code package will be removed, in favor of the ts cli.
the ts cli / edgezero cli will have auditing and config store primitives, so I'd hold off and rework this when those are in place
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ts-config, a standalone CLI that validates, matches, lints, and checkscreative-opportunities.tomlwithout requiring a Rust toolchain — directly addressing the JS auditor onboarding gap raised in Build a standalone validation tool for creative-opportunities.toml #701Changes
docs/superpowers/specs/2026-05-19-ts-config-cli-design.mdts-configCLI (1440 lines)Closes
Closes #701
Test plan
cargo test --workspacecargo clippy --workspace --all-targets --all-features -- -D warningscargo fmt --all -- --checkcd crates/js/lib && npx vitest runcd crates/js/lib && npm run formatcd docs && npm run formatcargo build --package trusted-server-adapter-fastly --release --target wasm32-wasip1fastly compute serveChecklist
unwrap()in production code — useexpect("should ...")tracingmacros (notprintln!)