Skip to content

fix: include repo-less dependencies in scoped deploys#209

Draft
vigneshrajsb wants to merge 1 commit into
mainfrom
vb/docker-dependency-repo-scope
Draft

fix: include repo-less dependencies in scoped deploys#209
vigneshrajsb wants to merge 1 commit into
mainfrom
vb/docker-dependency-repo-scope

Conversation

@vigneshrajsb
Copy link
Copy Markdown
Contributor

@vigneshrajsb vigneshrajsb commented May 22, 2026

Summary

This change fixes repo-scoped deploy flows so repo-less Docker dependencies are included when they are required by the selected deployable.

Root cause

Repo-less Docker deployables were being coerced from null to 0 when deploy records were created. Later repo-scoped build, deploy, manifest, fingerprint, and image-detail paths filtered only by repository id, so required Docker dependencies could have deploy records but still be skipped by later phases.

Changes

  • Preserve null repository ids for repo-less deployables.
  • Add a shared scope helper that includes the selected repository deployables plus their dependency closure.
  • Apply that scope consistently across deploy initialization, image builds, CLI deploys, manifest application, fingerprints, and running-image updates.
  • Add focused regression tests for repo-less Docker dependency inclusion and running-image updates.

Validation

  • DATABASE_URL=postgres://lifecycle:lifecycle@127.0.0.1:5432/lifecycle LIFECYCLE_MODE=server APP_ENV=test pnpm exec jest --runTestsByPath src/server/lib/__tests__/deployScope.test.ts src/server/services/__tests__/deploy.test.ts src/server/services/__tests__/build.test.ts --runInBand
  • pnpm run lint
  • pnpm run ts-check was run and still fails on existing repo-wide strict-null/type errors unrelated to this change.

@vigneshrajsb vigneshrajsb force-pushed the vb/docker-dependency-repo-scope branch from 9e4f335 to c0c5e8c Compare May 22, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant