fix: include repo-less dependencies in scoped deploys#209
Draft
vigneshrajsb wants to merge 1 commit into
Draft
Conversation
9e4f335 to
c0c5e8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change fixes repo-scoped deploy flows so repo-less Docker dependencies are included when they are required by the selected deployable.
Root cause
Repo-less Docker deployables were being coerced from
nullto0when deploy records were created. Later repo-scoped build, deploy, manifest, fingerprint, and image-detail paths filtered only by repository id, so required Docker dependencies could have deploy records but still be skipped by later phases.Changes
nullrepository ids for repo-less deployables.Validation
DATABASE_URL=postgres://lifecycle:lifecycle@127.0.0.1:5432/lifecycle LIFECYCLE_MODE=server APP_ENV=test pnpm exec jest --runTestsByPath src/server/lib/__tests__/deployScope.test.ts src/server/services/__tests__/deploy.test.ts src/server/services/__tests__/build.test.ts --runInBandpnpm run lintpnpm run ts-checkwas run and still fails on existing repo-wide strict-null/type errors unrelated to this change.