Centralize MUD branding configuration#465
Open
sarahmaeve wants to merge 1 commit intoGoMudEngine:masterfrom
Open
Centralize MUD branding configuration#465sarahmaeve wants to merge 1 commit intoGoMudEngine:masterfrom
sarahmaeve wants to merge 1 commit intoGoMudEngine:masterfrom
Conversation
Add Tagline, Description, URL, DiscordURL, AdminName, and AdminEmail
fields to the Server config section so operators can rebrand entirely
from config.yaml without editing templates or recompiling.
Templates now use {{ branding "Field" }} calls instead of hardcoded
strings for the MUD name, tagline, project URL, and Discord link.
Closes #84
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Volte6
requested changes
Apr 6, 2026
Member
Volte6
left a comment
Volte6
left a comment
There was a problem hiding this comment.
Good: New branding fields
Request change: Use a more generic template function name that can be used for any config value
| }, | ||
| "map": makeMap, | ||
| "t": language.T, | ||
| "branding": func(field string) string { |
Member
There was a problem hiding this comment.
Curious - why a branding keyword instead of a config keyword with a path to the value you want to display? I think that would be more generally useful.
For example: {{ config "Server.Description" }}, {{ config "GamePlay.Death.ProtectionLevels" }} etc.
I do like the additional fields, though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tagline,Description,URL,DiscordURL,AdminName,AdminEmail) toServerconfig section{{ branding "Field" }}template function so templates read from config instead of hardcoding stringsdefaultandemptyworlds to use the new functionconfig.yamlwithout editing templates or recompilingTest plan
go vet ./...passesgo build ./...compiles cleanlygofmt -l .reports no unformatted fileshelp about, verify it shows branding from configServer.Taglinein config.yaml, restart, verify it updates on the splash screen🤖 Generated with Claude Code