Skip to content

fix(ModelMappings): Added removed_components mapping to follow previo…#1272

Open
MelchiorSchuh wants to merge 3 commits into
nextfrom
fix/added_removed_components_mapping
Open

fix(ModelMappings): Added removed_components mapping to follow previo…#1272
MelchiorSchuh wants to merge 3 commits into
nextfrom
fix/added_removed_components_mapping

Conversation

@MelchiorSchuh
Copy link
Copy Markdown
Member

…us changes

@MelchiorSchuh MelchiorSchuh requested review from BotellaA and panquez May 18, 2026 11:53
@github-actions
Copy link
Copy Markdown
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 2 concern(s)
  • include/geode/model/representation/core/mapping.hpp:46:11: warning: [cppcoreguidelines-special-member-functions]

    class 'ModelMapping' defines a copy constructor, a copy assignment operator, a move constructor and a move assignment operator but does not define a destructor

       46 |     class ModelMapping
          |           ^
  • include/geode/model/representation/core/mapping.hpp:99:55: warning: [readability-identifier-naming]

    invalid case style for private member 'mappings'

       59 |             mappings.erase( type );
          |             ~~~~~~~~
          |             mappings_
       60 |         }
       61 | 
       62 |         [[nodiscard]] MappingType& operator[]( const ComponentType& type )
       63 |         {
       64 |             return mappings[type];
          |                    ~~~~~~~~
          |                    mappings_
       65 |         }
       66 | 
       67 |         [[nodiscard]] const absl::flat_hash_map< ComponentType, Mapping >&
       68 |             components_mappings() const
       69 |         {
       70 |             return mappings;
          |                    ~~~~~~~~
          |                    mappings_
       71 |         }
       72 | 
       73 |     private:
       74 |         absl::flat_hash_map< ComponentType, Mapping > mappings;
          |                                                       ^~~~~~~~
          |                                                       mappings_

Have any feedback or feature suggestions? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants