GPII-2165: Adding NP sets for manual MM QA

[kavyakomuru]

No description provided.

[gpii-bot]

Could one of the admins verify that these changes are reasonable to test? If so, please reply with "ok to test".

[javihernandez]

ok to test

[gpii-bot]

CI job passed.

[gpii-bot]

CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details.

[gpii-bot]

CI job passed.

[gpii-bot]

Could one of the admins verify that these changes are reasonable to test? If so, please reply with "ok to test".

[gtirloni]

ok to test

[gpii-bot]

CI job passed.

[kaspermarkus]

Hi @kavyakomuru Sorry for being so slow at reviewing this pull request.. I think it generally looks good and pretty much ready to go - a few comments though:

• I think it would be ok for now to drop all these directly into the "preferences" folder, since I think it'll be a while before we get the functionality to search recursively through the preferences folder. It's up to you, but if you want to avoid having to copy them over each time you do the QA, I think it would be ok to move them out of the QA folder
• The description in each NP set is great, only suggestion is to put a link to the MM QA test plan in each of the NP set, so one can get a clearer context of what they're used for

[kaspermarkus]

Ugh, just realized that the preferences server doesn't support json5 files right now... This is something that we want to support in the future but it hasn't happened yet (https://issues.gpii.net/browse/GPII-502 )

Could you move the comments out to *.md files with the same name as the NP sets (e.g. MMQAUserA.md) and rename all the NP sets you've added to .json

[kaspermarkus]

Added some comments that should be addressed before this can be merged