GPII-2046: Ensure that settings handlers always write to active profiles#477
GPII-2046: Ensure that settings handlers always write to active profiles#477javihernandez wants to merge 2 commits intoGPII:masterfrom
Conversation
|
CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details. |
|
CI job passed. |
1 similar comment
|
CI job passed. |
| "settingsHandlers": { | ||
| "configuration": { | ||
| "type": "gpii.orca", | ||
| "options": { |
There was a problem hiding this comment.
Is there no corresponding linux pull request to this? What does the settings handler do if the user token is not supplied?
There was a problem hiding this comment.
No, there's no linux side for this. As I mentioned back in the meeting we talked about this thing I removed this constraint in Orca settings handler during the last update but I forgot to remove the universal "bits" of it. I agree that this can be ready to go in as a separate pull request since we still need to make some accommodations in UNIVERSAL before the real issue (GPII-2046) can be addressed. Let me know if you want me to make a new JIRA/pr and get this merged ASAP.
|
ok to test |
|
CI job passed. |
|
Will pick up again when a higher priority solution needs this functionality |
5 participants
See https://issues.gpii.net/browse/GPII-2046.
Work in progress - not ready to be merged.