GPII-1256: Passing of web-solutions to the matchmakers#399
GPII-1256: Passing of web-solutions to the matchmakers#399kaspermarkus wants to merge 1 commit intoGPII:masterfrom
Conversation
There was a problem hiding this comment.
We can't have this stuck into the MatchMakerFramework base utilities like this - it needs to be a feature of a particular kind of FlowManager on a particular platform. Also, modifying the input payload mustn't happen
|
@simonbates pull is at #389 and is covered under GPII-1224 - you should make sure that you are both clear what the interaction of these two pull requests will be and add explanation to GPII-1256 which is currently inadequately documented. This pull request also needs to update all the documentation for affected payloads and workflow, some of which is in this repo and some of which is in the wiki. E.g. https://github.com/kaspermarkus/universal/blob/GPII-1256/documentation/loginFlow.md needs to be updated (in fact it is already quite stale with respect to the actual current workflow) |
kaspermarkus
changed the title
|
as @javihernandez pointed out, this pull request is also problematic wrt the browserChannel: https://github.com/GPII/universal/blob/master/gpii/node_modules/flowManager/src/BrowserChannel.js#L28 |
This is a temporary hack, only for the review4 branch. See GPII#399 (comment)
|
CI job passed. |
|
ok to test |
|
CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details. |
4 participants
Initial pull requests for feedback