GPII-1251: Initial version of PCP socket connector.

[kaspermarkus]

Only contains ability to send messages to the PCP as well as notifications for logging in and out.

Separate pull requests will follow for supporting from the PCP to notify of modified adjuster values, as well as support for the "try-harder" user feedback

[javihernandez]

Just a question.
Why do we want to pass the messages in every language in the world? Can't we just either:

• Let the PCP to translate the messages by itself
• Send the message in the language that the PCP is currently using

[kaspermarkus]

I dont think it would be possible to have the PCP translate the message itself, as the messages could be anything - and hence we wont be able to have a fixed translation table in the PCP. I agree though, that for fixed and well known messages (eg. for the "try harder" stuff, and so on) we could keep the text (and translations) in the PCP.

in terms of the second option, that might be a good idea - I hadn't considered it.. I guess I've been assuming that it was the job of the PCP to detect the language (since right now it runs in browser), decide on the fallback language, etc... but this assumption might be wrong

[amb26]

"language" should be a setting which we can determine from the user's preferences. It is, after all, our job to encode the user's preferences for UIs! It's not the PCP's job to detect the user's language, it is our job as the GPII - the browser's language is just one source of input, which, if we decided to listen to it, should be implemented as a settingsHandler in the usual way. In any case, Javi's original comment is correct - we should send the message in just the language which is appropriate.

[amb26]

WebSockets

[javihernandez]

Hey @kaspermarkus,

it looks like we're breaking some tests when merging this into our review4 branch.

17:23:48.706:  jq: FAIL: Module "multiuserTests.linux.integration tests" Test name "Login and logout of two users" - Message: Checking that settings are set - at sequence position 13 of 18
17:23:48.786:  jq: FAIL: Module "multiuserTests.linux.integration tests" Test name "Login and logout of two users" - Message: Successful logout message returned User with token multiuser1 was successfully logged in. - at sequence position 15 of 18
17:23:48.787:  jq: FAIL: Module "multiuserTests.linux.integration tests" Test name "Login and logout of two users" - Message: Checking that settings are properly reset - at sequence position 16 of 18
17:23:48.828:  jq: Test concluded - Module "multiuserTests.linux.integration tests" Test name "Login and logout of two users": 5/8 passed - FAIL
17:23:49.045:  jq: FAIL: Module "multiuserTests.linux.integration tests" Test name "Single user login followed by reset" - Message: Checking custom response - at sequence position 9 of 12
17:23:49.082:  jq: Test concluded - Module "multiuserTests.linux.integration tests" Test name "Single user login followed by reset": 3/4 passed - FAIL
17:23:49.377:  jq: FAIL: Module "multiuserTests.linux.integration tests" Test name "Dual user login followed by reset" - Message: Checking custom response - at sequence position 12 of 15
17:23:49.421:  jq: Test concluded - Module "multiuserTests.linux.integration tests" Test name "Dual user login followed by reset": 5/6 passed - FAIL
17:24:33.737:  ASSERTION FAILED: This failure is expected (flow manager save tests)
17:24:38.349:  jq: All tests concluded: 683/688 total passed in 59207ms - FAIL

As you can see, all of them are related to the multiUser feature, and presumably, due to the changes that are coming from kaspermarkus@a69ca63.
Please, can you take a look at it?

[kaspermarkus]

Due to multiUser code in review4, this one doesn't merge cleanly with review 4 -- A new pull request has been made for the review 4 branch, with the conflicts resolved: #410

[javihernandez]

JFYI
To perform manual tests, you can use this dummy client

[gpii-bot]

CI job passed.

[gtirloni]

ok to test

[gpii-bot]

CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details.

[kaspermarkus]

@javihernandez assigning this to you since you're doing the pcp backend work... When you dont need this any longer (e.g. you've made a new pull request or the like) feel free to close it