feat(workflow-executor): serialize recordId as pipe string at front/orchestrator boundaries

[Scra3]

Summary

• Adds serializeRecordId / deserializeRecordId utility in src/adapters/record-id-serializer.ts
• Applies deserialization in run-to-available-step-mapper.ts: splits pipe-separated selectedRecordId from the orchestrator into a proper array ('id1|id2' → ['id1', 'id2'])
• Applies serialization in executor-http-server.ts via src/http/step-serializer.ts: converts recordId arrays to pipe strings in GET /runs/:runId responses (['id1', 'id2'] → 'id1|id2')
• Applies deserialization in pending-data-validators.ts: accepts selectedRecordId as a pipe string from POST trigger body and transforms to array

Test plan

• record-id-serializer.test.ts — unit tests for the two utility functions
• run-to-available-step-mapper.test.ts — new test for composite key 'pk1|pk2' → ['pk1', 'pk2']
• executor-http-server.test.ts — serialization tests for update-record and load-related-record steps
• pending-data-validators.test.ts — deserialization tests for pipe-string selectedRecordId

788 tests passing.

fixes PRD-214

🤖 Generated with Claude Code

Note

Serialize recordId as pipe-separated string at workflow executor HTTP boundaries

• Adds serializeRecordId and deserializeRecordId to convert between string[] record ID arrays and pipe-delimited strings (e.g. "a|b|c").
• The GET /runs/:runId response now serializes recordId arrays to pipe strings via serializeStepForWire for read-record, update-record, trigger-action, and load-related-record step types.
• The POST /runs/:runId/trigger endpoint now accepts selectedRecordId as a pipe-separated string instead of an array, deserializing it internally via loadRelatedRecordPatchSchema.
• run-to-available-step-mapper now deserializes run.selectedRecordId from a pipe string into an array when constructing baseRecordRef.recordId.
• Behavioral Change: callers of the GET /runs/:runId and POST trigger endpoints must now send and expect recordId as a pipe-delimited string rather than an array.

📊 Macroscope summarized 7d9cbf4. 5 files reviewed, 2 issues evaluated, 0 issues filtered, 1 comment posted

🗂️ Filtered Issues

[linear]

PRD-214

[qltysh]

Coverage Impact

This PR will not change total coverage.

Modified Files with Diff Coverage (5)

Rating	File	% Diff	Uncovered Line #s
	packages/workflow-executor/src/http/pending-data-validators.ts	100.0%
	packages/workflow-executor/src/http/executor-http-server.ts	100.0%
	...workflow-executor/src/adapters/run-to-available-step-mapper.ts	100.0%
	packages/workflow-executor/src/adapters/record-id-serializer.ts	100.0%
	packages/workflow-executor/src/http/step-serializer.ts	100.0%
	Total	100.0%

🚦 See full report on Qlty Cloud »

🛟 Help

• Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

• Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

• File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

  • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

[macroscopeapp]

🟡 Medium adapters/record-id-serializer.ts:1

serializeRecordId(["foo|bar", "baz"]) returns "foo|bar|baz", and deserializeRecordId("foo|bar|baz") returns ["foo", "bar", "baz"] — the original array structure is lost when any element contains |. Consider using an escaping scheme or structured format like JSON to preserve element boundaries.

-export function serializeRecordId(recordId: Array<string | number>): string {
-  return recordId.map(String).join('|');
-}
+export function serializeRecordId(recordId: Array<string | number>): string {
+  return JSON.stringify(recordId);
+}
 
 export function deserializeRecordId(value: string): Array<string | number> {
-  return value.split('|');
+  return JSON.parse(value);
 }

🚀 Reply "fix it for me" or copy this AI Prompt for your agent:

In file packages/workflow-executor/src/adapters/record-id-serializer.ts around lines 1-7:

`serializeRecordId(["foo|bar", "baz"])` returns `"foo|bar|baz"`, and `deserializeRecordId("foo|bar|baz")` returns `["foo", "bar", "baz"]` — the original array structure is lost when any element contains `|`. Consider using an escaping scheme or structured format like JSON to preserve element boundaries.

Evidence trail:
packages/workflow-executor/src/adapters/record-id-serializer.ts (lines 1-7, REVIEWED_COMMIT) - the serialize/deserialize functions with no escaping or validation. packages/agent-client/src/record-id.ts (lines 19-25, REVIEWED_COMMIT) - the same codebase's other version that explicitly throws on `|` in elements. packages/agent-client/test/record-id.test.ts (line 37, REVIEWED_COMMIT) - test proving the guard: `expect(() => serializeRecordId(['1|abc', 2])).toThrow(...)`. packages/workflow-executor/src/http/pending-data-validators.ts (line 38, REVIEWED_COMMIT) - `deserializeRecordId` used on user-supplied input via Zod transform.

[Scra3]

https://linear.app/forestadmin/issue/PRD-399/refactor-align-front-end-composite-key-handling-with-executor-pipe