Skip to content

fix(scripts): remove unreachable branch in validate-modules.js #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shaun0927 wants to merge 1 commit into from
+6 −11
Closed

fix(scripts): remove unreachable branch in validate-modules.js #406

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions scripts/validate-modules.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,12 @@ for (const m of modules) {
process.exit(1);
}

if (t === 'object') {
const keys = Object.keys(exported);
for (const k of keys) {
if (typeof exported[k] === 'function') {
if (typeof exported[k] !== 'function') {
console.error('FAIL: ' + m + '.' + k + ' is declared but not a callable function');
process.exit(1);
}
}
}
}
// Previously this block contained a nested `typeof === 'function'` test
// inside `typeof === 'function'`, which was trivially false and made the
// intended "declared but not callable" warning unreachable. Without a
// declaration manifest we cannot tell which exported keys are expected
// to be functions, so the block is left as a no-op but the dead branch
// is removed to avoid giving false assurance.
checked++;
}

Expand Down