Skip to content

ECOM-16792 - add ancestor ids to CategoryInfo #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vlka597 merged 1 commit into from
May 20, 2026
+23 −0
Merged

ECOM-16792 - add ancestor ids to CategoryInfo #556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/kotlin/com/ecwid/apiclient/v3/dto/product/result/FetchedProduct.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ data class FetchedProduct(
val enabled: Boolean = true,
val name: String = "",
val nameTranslated: String = "",
val ancestorIds: List<Long>? = null,
)

data class TaxInfo(
Expand Down
19 changes: 19 additions & 0 deletions src/test/kotlin/com/ecwid/apiclient/v3/jsontransformer/gson/GsonTransformerTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@ package com.ecwid.apiclient.v3.jsontransformer.gson
import com.ecwid.apiclient.v3.dto.common.NullableUpdatedValue
import com.ecwid.apiclient.v3.dto.order.request.UpdatedOrder
import com.ecwid.apiclient.v3.dto.product.request.UpdatedProduct
import com.ecwid.apiclient.v3.dto.product.result.FetchedProduct
import com.ecwid.apiclient.v3.impl.ParsedResponseWithExt
import com.google.gson.JsonParser
import org.junit.jupiter.api.Assertions.assertEquals
import org.junit.jupiter.api.Test
import kotlin.test.assertNull

internal class GsonTransformerTest {

Expand Down Expand Up @@ -230,6 +232,23 @@ internal class GsonTransformerTest {
)
}

@Test
fun `test deserialization of FetchedProduct CategoryInfo with ancestorIds`() {
val json = """{"categories": [{"id": 42, "enabled": true, "name": "Cat", "nameTranslated": "", "ancestorIds": [1, 7]}]}"""
val product = transformer.deserialize(json, FetchedProduct::class.java)
assertEquals(
listOf(FetchedProduct.CategoryInfo(id = 42, enabled = true, name = "Cat", nameTranslated = "", ancestorIds = listOf(1L, 7L))),
product.categories
)
}

@Test
fun `test deserialization of FetchedProduct CategoryInfo without ancestorIds defaults to null`() {
val json = """{"categories": [{"id": 42, "enabled": true, "name": "Cat", "nameTranslated": ""}]}"""
val product = transformer.deserialize(json, FetchedProduct::class.java)
assertNull(product.categories?.first()?.ancestorIds)
}

@Test
fun `deserializeOrNull of broken ParsedResponseWithExt`() {
val json = "'testField': {'baseField': 'base', 'extField': 'ext'}}"
Expand Down
3 changes: 3 additions & 0 deletions src/test/kotlin/com/ecwid/apiclient/v3/rule/NullablePropertyRules.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import com.ecwid.apiclient.v3.dto.order.result.DeletedOrder
import com.ecwid.apiclient.v3.dto.payment.PaymentAppRequest
import com.ecwid.apiclient.v3.dto.product.request.ProductInventoryUpdateRequest
import com.ecwid.apiclient.v3.dto.product.request.ProductUpdateRequest
import com.ecwid.apiclient.v3.dto.product.result.FetchedProduct.CategoryInfo
import com.ecwid.apiclient.v3.dto.product.result.GetProductFiltersResult
import com.ecwid.apiclient.v3.dto.product.result.ProductInventoryUpdateResult
import com.ecwid.apiclient.v3.dto.productreview.request.UpdatedProductReviewStatus
Expand Down Expand Up @@ -161,6 +162,8 @@ val otherNullablePropertyRules: List<NullablePropertyRule<*, *>> = listOf(

AllowNullable(CustomerGroupsSearchRequest::keyword),
AllowNullable(CustomerGroupsSearchRequest::customerGroupIds),

AllowNullable(CategoryInfo::ancestorIds)
)

val nullablePropertyRules: List<NullablePropertyRule<*, *>> = listOf(
Expand Down
Loading