Add a function for finding input datasets for derived variables#3051
Draft
bouweandela wants to merge 2 commits intomainfrom
Draft
Add a function for finding input datasets for derived variables#3051bouweandela wants to merge 2 commits intomainfrom
bouweandela wants to merge 2 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (14.28%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3051 +/- ##
==========================================
- Coverage 96.15% 96.08% -0.08%
==========================================
Files 270 270
Lines 15805 15819 +14
==========================================
+ Hits 15198 15199 +1
- Misses 607 620 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
10 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Alternative implementation to #2777 for finding input datasets for derived variables. Adds a method
esmvalcore.dataset.Dataset.derived_variable_from_filesthat can be used to find input datasets.Note that derived variables with optional input datasets are not yet supported. The only derived variable that uses this feature is
amocat the moment, so the impact of that is limited.Link to documentation: https://esmvaltool--3051.org.readthedocs.build/projects/ESMValCore/en/3051/notebooks/derived-variables.html
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: