Skip to content

Don't Stop Believin' ... when CORDEX grid is non-standard#3034

Draft
bouweandela wants to merge 3 commits intomainfrom
relax-cordex-grid-fix
Draft

Don't Stop Believin' ... when CORDEX grid is non-standard#3034
bouweandela wants to merge 3 commits intomainfrom
relax-cordex-grid-fix

Conversation

@bouweandela
Copy link
Copy Markdown
Member

@bouweandela bouweandela commented Mar 27, 2026

Description

Related to #2036 (comment)

Maybe we should just switch to using cordex.rewrite_coords instead of implementing our own capability to fix the coordinates.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@bouweandela bouweandela added the fix for dataset Related to dataset-specific fix files label Mar 27, 2026
@valeriupredoi valeriupredoi changed the title Do not stop when CORDEX grid is non-standard Don't Stop Believin' ... when CORDEX grid is non-standard Apr 7, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

❌ Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.14%. Comparing base (df77d1b) to head (d7b8bbe).

Files with missing lines Patch % Lines
esmvalcore/cmor/_fixes/cordex/cordex_fixes.py 90.90% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (90.90%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3034      +/-   ##
==========================================
- Coverage   96.15%   96.14%   -0.02%     
==========================================
  Files         270      270              
  Lines       15805    15810       +5     
==========================================
+ Hits        15197    15200       +3     
- Misses        608      610       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix for dataset Related to dataset-specific fix files

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

1 participant