Skip to content

Feat: update SDWebImage to latest ver#1034

Open
Naturalclar wants to merge 1 commit intoDylanVann:mainfrom
Naturalclar:fix/updateSDWebImage
Open

Feat: update SDWebImage to latest ver#1034
Naturalclar wants to merge 1 commit intoDylanVann:mainfrom
Naturalclar:fix/updateSDWebImage

Conversation

@Naturalclar
Copy link
Copy Markdown
Contributor

resolves #1031

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 21, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (54376d8) to head (0b68b14).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1034   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           38        38           
  Branches         5         5           
=========================================
  Hits            38        38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.


s.dependency 'React-Core'
s.dependency 'SDWebImage', '~> 5.11.1'
s.dependency 'SDWebImage', '~> 5.18.7'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to use more relaxed version requirements like:

s.dependency 'SDWebImage', '~> 5.18'
s.dependency 'SDWebImageWebPCoder', '~> 0.14'

This is more conventional in podspecs unless we have a really good reason to restrict it.

@Vyazovoy
Copy link
Copy Markdown

@DylanVann, could you please consider merging this PR with suggested changes and make a patch release? That would unblock a lot of people as we have to update SDWebImage to the latest version to make it comply with the Apple Privacy Manifest requirements (by May).

@gsantiago
Copy link
Copy Markdown

@DylanVann do you have plans to merge this PR? We also need the updated version of SDWebImage with the Apple Privacy Manifest

@divvieesterhuizen
Copy link
Copy Markdown

@DylanVann this PR seems like a great idea. Maybe merge it in ?

@ameer2468
Copy link
Copy Markdown

ameer2468 commented Jul 15, 2024

@DylanVann Please consider responding - you're active on Github based on your profile, it will be highly appreciated if you can get the PRs merged. Many, including me, really want to use this package in production.

Until then, i recommend everyone to switch to https://docs.expo.dev/versions/latest/sdk/image/ - if you're using Expo this is a good alternative.

Make sure to use the cachePolicy value in order to have a peformant grid image component.

@deepanshushuklad11
Copy link
Copy Markdown

DreamSportsLab has forked this repo and created new package .
@d11/react-native-fast-image
Dream11 is actively maintaining this new package and will be fixing relevant and reproducible issues of this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to SDWebImage to 5.18.7 or higher for privacy manifest before Apple's May 1 deadline

6 participants