recipes: use nobranch=1 for upstream git sources#41
Open
Conversation
Replace branch= with nobranch=1 in OVMF and ZFS recipes since SRCREV is already pinned to specific commits. This makes fetching more robust against upstream branch rebases or renames.
There was a problem hiding this comment.
Pull request overview
This PR improves fetch robustness for git-based Yocto recipes by removing dependency on upstream branch names when SRCREV is already pinned to an exact commit.
Changes:
- Update the ZFS recipe to use
nobranch=1instead ofbranch=zfs-2.2-release. - Update the OVMF/edk2 recipe to use
nobranch=1instead ofbranch=master.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| meta-dstack/recipes-core/dstack-zfs/dstack-zfs_2.2.5.bb | Switch git fetch parameters to nobranch=1 while keeping SRCREV pinned for reproducible fetches. |
| meta-dstack/recipes-core/dstack-ovmf/dstack-ovmf_git.bb | Switch gitsm fetch parameters to nobranch=1 to avoid failures if the upstream default branch changes/rebases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
branch=masterwithnobranch=1in OVMF recipebranch=zfs-2.2-releasewithnobranch=1in ZFS recipeTest plan
bitbake dstack-ovmffetches and builds successfullybitbake dstack-zfsfetches and builds successfully