test: extend and consolidate tag inheritance tests into test_tag_inheritance.py#14771
Open
valentijnscholten wants to merge 4 commits intoDefectDojo:devfrom
Open
test: extend and consolidate tag inheritance tests into test_tag_inheritance.py#14771valentijnscholten wants to merge 4 commits intoDefectDojo:devfrom
valentijnscholten wants to merge 4 commits intoDefectDojo:devfrom
Conversation
Move all tag-inheritance-related tests into a single file: - InheritedTagsTests, InheritedTagsImportMixin, InheritedTagsImportTestAPI, InheritedTagsImportTestUI from test_tags.py - TestTagInheritanceOnPersist from test_bulk_locations.py - test_tags_signals.py (new unit tests, now absorbed) Add new unit test classes covering tags_signals.py internals: - TestGetProducts — isinstance routing for all model types - TestInheritProductTags — per-product and system-wide flag gating - TestPropagateInheritanceEarlyExit — early-exit short-circuit logic Add class-level docstrings throughout for clarity. Fix SSL redirect in InheritedTagsImportTestAPI/UI setUp.
valentijnscholten
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unittests/test_tag_inheritance.pyfile, consolidating fromtest_tags.py,test_bulk_locations.py, and the now-deletedtest_tags_signals.pytags_signals.pyinternals:TestGetProducts,TestInheritProductTags,TestPropagateInheritanceEarlyExit