Remove deleted files as a part of the git sync path#2152
Merged
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With this PR, deactivating nodes and then clicking "Sync to Git" now actually removes the stale YAMLs from the branch, rather than leaving orphans behind or 422-ing on empty namespaces.
The changes include:
sync_namespace_to_gitnow detects orphan YAMLs in the existing git tree (paths under git_path that don't correspond to any active node in the namespace (e.g. deactivated nodes), and includes them as deletions in the same commit. dj.yaml is filtered out so it's never deleted.GitHubService.commit_filesaccepts a deletions list, which are added to the tree as entries, which removes the path from the base tree in a single Git Data API commit.deleted N file(s)log when deletions occurred.Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan