Open
Conversation
Contributor
Author
|
Waits until we have released before enabling. |
Contributor
|
kan vi gjøre det i playground også? |
eirinsvi
approved these changes
Apr 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR switches the solution’s MAUI XAML inflation from legacy XamlC (IL weaving) to the SourceGen-based inflator to improve Hot Reload support and build/debug performance, and adjusts a few component properties to be compatible with SourceGen’s generated setters.
Changes:
- Enable
MauiXamlInflator=SourceGenacross the library and app projects. - Change select component properties from
inittosetso SourceGen can assign them during XAML inflation. - Bump
CHANGELOG.mdwith a new release entry for the SourceGen switch.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/library/DIPS.Mobile.UI/DIPS.Mobile.UI.csproj |
Enables SourceGen XAML inflator for the UI component library. |
src/library/DIPS.Mobile.UI/Components/Lists/ScrollView/ScrollView.Properties.cs |
Changes RemoveFocusOnScroll to a settable property for SourceGen compatibility. |
src/library/DIPS.Mobile.UI/Components/Lists/CollectionView/CollectionView.Properties.cs |
Changes RemoveFocusOnScroll and corner radius properties to settable for SourceGen compatibility. |
src/app/Playground/Playground.csproj |
Enables SourceGen XAML inflator for the Playground app. |
src/app/MemoryLeakTests/MemoryLeakTests.csproj |
Enables SourceGen XAML inflator for the memory leak test app. |
src/app/Components/Components.csproj |
Enables SourceGen XAML inflator for the Components app. |
CHANGELOG.md |
Adds a new version entry documenting the SourceGen switch. |
Contributor
Author
Dæ e satt der også ja |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
haavamoa
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Switches XAML inflation from the legacy
XamlC(IL-weaving) approach to the newSourceGensource-generator-based compilation. Benefits:Changes
Enable
MauiXamlInflator=SourceGenin all projects:DIPS.Mobile.UI(library)Components,Playground,MemoryLeakTests(apps)Change
init→seton properties that SourceGen needs to set during XAML inflation:CollectionView.RemoveFocusOnScrollCollectionView.FirstItemCornerRadiusCollectionView.LastItemCornerRadiusScrollView.RemoveFocusOnScrollSourceGen generates code that assigns property values directly (rather than IL-weaving), so properties set from XAML must have a public
setaccessor —initis not sufficient.