Conversation
shaeespring
force-pushed
the
makePRs
branch
2 times, most recently
from
a3ae459 to
ac15caa
Compare
Contributor
Author
|
Okay, I think this is what I want. Basically, if your code doesn't pass the check, it's probably not ready for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check one:
Summary of change(s):
Makes it so reviewers can focus on semantics, not silly other things, on their local machine
Could also do the Docker thing, but it's the same thing and takes so much longer.I forgot make won't work if it has nothing else installed :/