Skip to content

mctpd: init response header before early returns #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
msnidhin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

mctpd: init response header before early returns #151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/mctpd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1233,6 +1233,10 @@ handle_control_endpoint_discovery(struct ctx *ctx, int sd,
return 0;
}

req = (void *)buf;
resp = (void *)resp;
mctp_ctrl_msg_hdr_init_resp(&resp->ctrl_hdr, *req);

if (link_data->discovered == DISCOVERY_UNSUPPORTED) {
resp->completion_code = MCTP_CTRL_CC_ERROR_INVALID_DATA;
return reply_message(ctx, sd, resp,
Expand All @@ -1244,10 +1248,6 @@ handle_control_endpoint_discovery(struct ctx *ctx, int sd,
return 0;
}

req = (void *)buf;
resp = (void *)resp;
mctp_ctrl_msg_hdr_init_resp(&resp->ctrl_hdr, *req);

// we need to send using physical addressing, no entry in routing table yet
return reply_message_phys(ctx, sd, resp, sizeof(*resp), addr);
}
Expand Down
Loading