Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,13 @@
"test": "vitest run",
"typecheck": "tsc --noEmit",
"lint": "eslint .",
"format": "prettier --write ."
"format": "prettier --write .",
"scrape:courses": "node scripts/scrape-courses.ts"
},
"dependencies": {
"@dagrejs/dagre": "^3.0.0",
"@xyflow/react": "^12.10.2",
"cheerio": "^1.2.0",
"react": "^19.2.6",
"react-dom": "^19.2.6",
"react-router-dom": "^7.15.1",
Expand Down
179 changes: 179 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1,194 changes: 1,194 additions & 0 deletions scripts/fixtures/MathStats_courses.html

Large diffs are not rendered by default.

916 changes: 916 additions & 0 deletions scripts/fixtures/cs_courses.html

Large diffs are not rendered by default.

437 changes: 437 additions & 0 deletions scripts/fixtures/programsPage.html

Large diffs are not rendered by default.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two related cleanups:

  • The test writes scripts/output/courses-scraped.json and console.logs on import - assertions should run in memory; producing the file is scrape()'s job. Please drop the writeFileSync/logs from the test.
  • That output JSON is a generated artifact, so it shouldn't be tracked - add scripts/output/*.json to .gitignore and keep the folder with a .gitkeep.
  • Keep the scripts/fixtures/*.html committed, though - those are the test inputs that let the tests run offline, exactly as the ticket intends. Nice work!

Empty file.
Loading
Loading