Conversation
✅ Deploy Preview for birminghack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This pull request has been marked to automatically sync to its base branch. You can disable this behavior by removing the label. |
Thatsmusic99
left a comment
Thatsmusic99
left a comment
There was a problem hiding this comment.
idk how fuckin css works
There was a problem hiding this comment.
Pull request overview
This PR introduces an Archive section for past events, migrates event content into _data files, and updates the countdown so it continues to show meaningful text/time after the event window has passed.
Changes:
- Move 2025/2026 event content into
_data/2025.yamland_data/2026.yaml, and render pages from those data files. - Add archive pages for 2025 and 2026 and update navigation to be driven by a configurable menu (with dropdown support).
- Update the countdown include to switch messaging for “ends” and “since ended” states.
Reviewed changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
index.html |
Switches homepage to render from site.data['2026'] and updates ticket + countdown rendering. |
css/main.scss |
Adds styling for archive “about” section and dropdown navigation. |
assets/birminghack2-logo-vec.svg |
Adds a vector logo asset for the 2026 edition. |
assets/birminghack1-logo-vec.svg |
Adds a vector logo asset for the 2025 edition. |
archive/2026/index.html |
Adds an archive page rendering the 2026 event from _data/2026.yaml. |
archive/2025/index.html |
Adds an archive page rendering the 2025 event from _data/2025.yaml. |
_layouts/master.html |
Fixes favicon path to be root-relative. |
_includes/nav.html |
Replaces hardcoded nav items with config-driven menu + dropdown support. |
_includes/footer.html |
Fixes CSS logo image path to be root-relative. |
_includes/countdown.js |
Enhances countdown behavior for “during” and “after” event states. |
_data/2026.yaml |
Adds 2026 event data (schedule, partners, FAQs, ticket state, etc.). |
_data/2025.yaml |
Adds 2025 event data (schedule, sponsors, partners, FAQs, etc.). |
_config.yml |
Defines the site menu (including Archive dropdown). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # answer: | ||
| --- | ||
|
|
||
| {% assign page = site.data['2026'] %} |
There was a problem hiding this comment.
Avoid assigning to the special Liquid variable page (it represents the current page’s front matter and is used by layouts). Use a different variable name (e.g., event / event_data) for site.data['2026'] to prevent confusing behavior and accidental breakage if the layout relies on page.* fields later.
| font-size: var(--text-small); | ||
| } | ||
|
|
||
| nav .dropdown:hover .dropdown-content { |
There was a problem hiding this comment.
Dropdown visibility is controlled only via :hover, which makes the archive menu difficult/impossible to use with keyboard navigation and many touch devices. Add a :focus-within (and/or explicit button + aria-expanded behavior) so the submenu can be opened without hovering.
| nav .dropdown:hover .dropdown-content { | |
| nav .dropdown:hover .dropdown-content, | |
| nav .dropdown:focus-within .dropdown-content { |
| layout: page | ||
| --- | ||
|
|
||
| {% assign page = site.data['2026'] %} |
There was a problem hiding this comment.
Avoid assigning to the special Liquid variable page here as well; it shadows the page object used by layouts (e.g., page.title, page.styles, etc.). Use a different variable name for the year data to keep template behavior predictable.
| layout: page | ||
| --- | ||
|
|
||
| {% assign page = site.data['2025'] %} |
There was a problem hiding this comment.
Avoid assigning to the special Liquid variable page here as well; it shadows the page object used by layouts (e.g., page.title, page.styles, etc.). Use a different variable name for the year data to keep template behavior predictable.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: 6C6565 <99056415+qPalee@users.noreply.github.com>
Added archive section and updated the countdown to work after the event is finished