Harden attachment download and repeater handling in pull sync#56
Open
manuel-be-one wants to merge 1 commit into
Open
Harden attachment download and repeater handling in pull sync#56manuel-be-one wants to merge 1 commit into
manuel-be-one wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the pull sync more resilient when handling repeaters and downloaded media attachments.
What changed
sub_fieldsbefore iterating.Why
The pull sync could fail or create inconsistent media entries when the remote asset was missing locally, when attachment metadata was stale, or when the downloaded filename already had an extension.
Testing