refactor: signAndSend sdk functions and ECDSA MPCv2 utils#216
Open
danielpeng1 wants to merge 1 commit into
Open
refactor: signAndSend sdk functions and ECDSA MPCv2 utils#216danielpeng1 wants to merge 1 commit into
danielpeng1 wants to merge 1 commit into
Conversation
danielpeng1
requested review from
mohammadalfaiyazbitgo,
pranavjain97 and
pranishnepal
pranishnepal
reviewed
Jun 1, 2026
Contributor
pranishnepal
left a comment
pranishnepal
left a comment
There was a problem hiding this comment.
some minor comments, lmk what u think
| sinon.assert.calledOnce(signAndSendStub); | ||
|
|
||
| sinon.restore(); | ||
| nocks.sendTxNock.done(); |
Contributor
There was a problem hiding this comment.
do we need to validate individual rounds here too?
| coin: 'hteth', | ||
| }); | ||
| function nockWalletAndSigningKeychain(coinName: string) { | ||
| nock(bitgoApiUrl) |
Contributor
There was a problem hiding this comment.
we can return the two nocks as objects like:
return { walletNock, keychainNock };
then at call site, we can invoke .done()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dropping stubs from
signAndSendTxRequest.test.tsto use real SDK signing paths.testUtils.ts.ecdsa.test.tsandsendMany.test.ts(andsignAndSendTxRequest.test.ts) to use these helpers.Ticket: WAL-1489