Skip to content

fix google signin#144

Closed
Pramad712 wants to merge 6 commits intomainfrom
google-signin-fix
Closed

fix google signin#144
Pramad712 wants to merge 6 commits intomainfrom
google-signin-fix

Conversation

@Pramad712
Copy link
Copy Markdown
Contributor

mainly for android ofc

Copilot AI review requested due to automatic review settings April 19, 2026 17:39
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 19, 2026

🚀 Expo preview is ready!

  • Project → audacity-music-club
  • Platforms → android, ios
  • Runtime Version → 1.0.0
  • More info

Learn more about 𝝠 Expo Github Action

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to fix Google Sign-In behavior (notably on Android) and align related Android app configuration with newer OS requirements.

Changes:

  • Adjust Google Sign-In configuration by removing offlineAccess.
  • Update Drive upload auth to fetch tokens via GoogleSignin.getTokens() instead of reading a stored token.
  • Update Android manifest permissions with maxSdkVersion gates and add a package visibility query for Google Play services.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/screens/SignInScreen.js Tweaks Google Sign-In configuration (removes offlineAccess).
src/components/UploadButton.js Switches access-token acquisition from AsyncStorage to Google Sign-In tokens API.
android/app/src/main/AndroidManifest.xml Updates storage permissions for modern Android and adds a queries entry for com.google.android.gms.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/components/UploadButton.js Outdated
Comment thread src/screens/SignInScreen.js Outdated
Comment thread src/screens/SignInScreen.js Outdated
Pramad712 and others added 2 commits April 19, 2026 10:44
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI and others added 2 commits April 19, 2026 17:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to fix Google Sign-In behavior (notably on Android) by centralizing Google Sign-In initialization and updating Drive upload token retrieval.

Changes:

  • Moved GoogleSignin.configure(...) out of SignInScreen and into app startup (App.js).
  • Updated Drive upload flow to fetch tokens directly from GoogleSignin.getTokens() (with a silent sign-in fallback) instead of AsyncStorage.
  • Adjusted Android manifest permissions (SDK-gated storage permissions) and added a Google Play Services package query.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/screens/SignInScreen.js Removes per-screen Google Sign-In configuration; updates header comment.
src/components/UploadButton.js Switches access-token retrieval to GoogleSignin.getTokens() with silent sign-in fallback.
android/app/src/main/AndroidManifest.xml Gates legacy storage permissions by SDK level; adds <queries> entry for Play Services.
App.js Adds global Google Sign-In configuration at app initialization with env var guards.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread App.js Outdated
Comment thread src/screens/SignInScreen.js
Comment thread src/components/UploadButton.js
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes Google Sign-In reliability (especially on Android) by moving Google Sign-In initialization to app startup and switching Drive uploads to fetch fresh tokens from the Google Sign-In SDK instead of persisting access tokens in storage.

Changes:

  • Initialize GoogleSignin.configure(...) in App.js on app mount (instead of in SignInScreen).
  • Stop persisting/removing "access-token" in AsyncStorage; Drive uploads now use GoogleSignin.getTokens() (with silent sign-in fallback).
  • Android manifest tweaks for storage permissions SDK bounds and package visibility for Play Services.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/screens/SignInScreen.js Removes Google Sign-In configuration from this screen and stops storing access tokens in AsyncStorage.
src/screens/AccountScreen.js Stops removing the legacy "access-token" key on logout (since it’s no longer used).
src/components/UploadButton.js Retrieves access tokens via GoogleSignin.getTokens() (and attempts signInSilently() on failure).
android/app/src/main/AndroidManifest.xml Adds SDK-bounded storage permissions and declares a Play Services package query.
App.js Configures Google Sign-In once at application startup with env var validation and platform guard.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Pramad712 Pramad712 closed this Apr 29, 2026
@Pramad712
Copy link
Copy Markdown
Contributor Author

just some random claude code stuff; none of these may be the actual issue

@Pramad712 Pramad712 deleted the google-signin-fix branch April 29, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants