Conversation
|
🚀 Expo preview is ready!
|
There was a problem hiding this comment.
Pull request overview
This PR aims to fix Google Sign-In behavior (notably on Android) and align related Android app configuration with newer OS requirements.
Changes:
- Adjust Google Sign-In configuration by removing
offlineAccess. - Update Drive upload auth to fetch tokens via
GoogleSignin.getTokens()instead of reading a stored token. - Update Android manifest permissions with
maxSdkVersiongates and add a package visibility query for Google Play services.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/screens/SignInScreen.js | Tweaks Google Sign-In configuration (removes offlineAccess). |
| src/components/UploadButton.js | Switches access-token acquisition from AsyncStorage to Google Sign-In tokens API. |
| android/app/src/main/AndroidManifest.xml | Updates storage permissions for modern Android and adds a queries entry for com.google.android.gms. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/AudacityMusic/signup/sessions/8c8b82a3-f5fd-4584-be69-bd6f645727de Co-authored-by: Pramad712 <77818951+Pramad712@users.noreply.github.com>
Agent-Logs-Url: https://github.com/AudacityMusic/signup/sessions/8c8b82a3-f5fd-4584-be69-bd6f645727de Co-authored-by: Pramad712 <77818951+Pramad712@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR aims to fix Google Sign-In behavior (notably on Android) by centralizing Google Sign-In initialization and updating Drive upload token retrieval.
Changes:
- Moved
GoogleSignin.configure(...)out ofSignInScreenand into app startup (App.js). - Updated Drive upload flow to fetch tokens directly from
GoogleSignin.getTokens()(with a silent sign-in fallback) instead of AsyncStorage. - Adjusted Android manifest permissions (SDK-gated storage permissions) and added a Google Play Services package query.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/screens/SignInScreen.js |
Removes per-screen Google Sign-In configuration; updates header comment. |
src/components/UploadButton.js |
Switches access-token retrieval to GoogleSignin.getTokens() with silent sign-in fallback. |
android/app/src/main/AndroidManifest.xml |
Gates legacy storage permissions by SDK level; adds <queries> entry for Play Services. |
App.js |
Adds global Google Sign-In configuration at app initialization with env var guards. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
This PR fixes Google Sign-In reliability (especially on Android) by moving Google Sign-In initialization to app startup and switching Drive uploads to fetch fresh tokens from the Google Sign-In SDK instead of persisting access tokens in storage.
Changes:
- Initialize
GoogleSignin.configure(...)inApp.json app mount (instead of inSignInScreen). - Stop persisting/removing
"access-token"in AsyncStorage; Drive uploads now useGoogleSignin.getTokens()(with silent sign-in fallback). - Android manifest tweaks for storage permissions SDK bounds and package visibility for Play Services.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/screens/SignInScreen.js | Removes Google Sign-In configuration from this screen and stops storing access tokens in AsyncStorage. |
| src/screens/AccountScreen.js | Stops removing the legacy "access-token" key on logout (since it’s no longer used). |
| src/components/UploadButton.js | Retrieves access tokens via GoogleSignin.getTokens() (and attempts signInSilently() on failure). |
| android/app/src/main/AndroidManifest.xml | Adds SDK-bounded storage permissions and declares a Play Services package query. |
| App.js | Configures Google Sign-In once at application startup with env var validation and platform guard. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
just some random claude code stuff; none of these may be the actual issue |
mainly for android ofc