fix: use host machine IP for real devices instead of adb reverse#94
Open
slava-markovski-unity wants to merge 1 commit into
Open
Conversation
adb reverse silently fails through ADB relay setups (STF, Headspin, and any device farm that proxies ADB connections). The reverse tunnel command exits 0 but is never established on the device side, so connections to localhost:PORT on the device get nothing and fail with 'unexpected end of stream'. Using the host machine's public IPv4 directly works for both physical devices (reachable over Wi-Fi on the same network as the Appium host) and emulators, with no regression. Verified on: - Local AVD (Android emulator) — fix works - STF with physical Pixel 6 running Android 16 — fix works
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
adb reversesilently fails through ADB relay setups (STF, Headspin, and any device farm that proxies ADB connections). The command exits0but the reverse tunnel is never actually established on the device side — from the device's perspective there is nothing listening onlocalhost:PORT, so every HTTPS CONNECT through the proxy fails with:This makes the plugin completely non-functional on any device farm using an ADB relay.
Fix
Use the host machine's public IPv4 for all device types instead of
localhost+adb reverse. Physical devices reach the proxy over Wi-Fi (they are on the same network as the Appium host in any standard device farm setup). Emulators can reach the host IP just as well as before.The
adb reversecall is removed since it is no longer needed.Verified on