Skip to content

Change export_merge_tree_partition_manifest_ttl to 86400 #1692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zvonand merged 2 commits into from
Apr 27, 2026
+2 −1
Merged

Change export_merge_tree_partition_manifest_ttl to 86400 #1692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f85d330
Change export_merge_tree_partition_manifest_ttl to 86400
arthurpassos Apr 27, 2026
5aa5d9c
Add new settings for export merge tree and iceberg
arthurpassos Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Core/Settings.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7368,7 +7368,7 @@ Ignore existing partition export and overwrite the zookeeper entry
DECLARE(UInt64, export_merge_tree_partition_max_retries, 3, R"(
Maximum number of retries for exporting a merge tree part in an export partition task
)", 0) \
DECLARE(UInt64, export_merge_tree_partition_manifest_ttl, 180, R"(
DECLARE(UInt64, export_merge_tree_partition_manifest_ttl, 86400, R"(
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add compatibility history for manifest TTL default change

This changes the default in Settings.cpp but does not add a corresponding entry in src/Core/SettingsChangesHistory.cpp, so SET compatibility = '<older version>' will not roll export_merge_tree_partition_manifest_ttl back to 180 even though applyCompatibilitySetting only reverts values recorded in that history map (Settings.cpp around lines 8026-8050). That makes this default change unexpectedly backward-incompatible for clusters relying on compatibility mode after upgrade.

Useful? React with 👍 / 👎.

Determines how long the manifest will live in ZooKeeper. It prevents the same partition from being exported twice to the same destination.
This setting does not affect / delete in progress tasks. It'll only cleanup the completed ones.
)", 0) \
Expand Down
1 change: 1 addition & 0 deletions src/Core/SettingsChangesHistory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ const VersionToSettingsChangesMap & getSettingsChangesHistory()
{"object_storage_remote_initiator_cluster", "", "", "New setting."},
{"iceberg_metadata_staleness_ms", 0, 0, "New setting allowing using cached metadata version at READ operations to prevent fetching from remote catalog"},
{"export_merge_tree_partition_task_timeout_seconds", 0, 3600, "New setting to control the timeout for export partition tasks."},
{"export_merge_tree_partition_manifest_ttl", 180, 86400, "Reasonable default for real usage"},
});
addSettingsChanges(settings_changes_history, "26.1",
{
Expand Down
Loading