[PWGCF] adding new analysis task for multiharmonic correlations#15896
Open
pengchon wants to merge 6 commits intoAliceO2Group:masterfrom
Open
[PWGCF] adding new analysis task for multiharmonic correlations#15896pengchon wants to merge 6 commits intoAliceO2Group:masterfrom
pengchon wants to merge 6 commits intoAliceO2Group:masterfrom
Conversation
pengchon
requested review from
alibuild,
jaelpark,
otonvd,
shouqiye,
victor-gonzalez and
wenyaCern
as code owners
github-actions
Bot
changed the title
|
O2 linter results: ❌ 16 errors, |
added 2 commits
April 21, 2026 14:47
| COMPONENT_NAME Analysis) | ||
|
|
||
| o2physics_add_dpl_workflow(multiharmonic-correlations | ||
| SOURCES multiharmonic-correlations.cxx |
Collaborator
There was a problem hiding this comment.
As suggested by the linter, please use multiharmonicCorrelations.cxx for source filename
| #include <TSystem.h> | ||
|
|
||
| #include <cstring> | ||
| #include <iostream> |
Collaborator
There was a problem hiding this comment.
Any reason for inluding iostream?
|
|
||
| // *) Define configurables: | ||
| Configurable<bool> cfDryRun{"cfDryRun", false, "book all histos and run without filling and calculating anything"}; // example for built-in type (float, string, etc.) | ||
| Configurable<vector<float>> cf_pt_bins{"cf_pt_bins", {1000, 0., 100.}, "nPtBins, ptMin, ptMax"}; // example for an array |
Collaborator
There was a problem hiding this comment.
Please, keep using std:: prefix for types on the std namespace
| // Once you have a valid pointer to "hist", add these technical lines: | ||
| hist->SetDirectory(0); // remove ownerhip from an external file | ||
| TH1F* histClone = reinterpret_cast<TH1F*>(hist->Clone()); // yes, I have to clone here | ||
| delete baseList; // release back the memory |
Collaborator
There was a problem hiding this comment.
Be careful here. If baseList comes from a CCDB stored object, it should not be deleted because it will cause a double deletion error when the workflow terminates
Comment on lines
+391
to
+392
| // LOGF(info, "Track azimuthal angle: %f", track.phi()); | ||
| // pc.histWeights=GetHistogramWithWeights(cfFileWithWeights.value.c_str(), "000123456"); |
Collaborator
There was a problem hiding this comment.
Please, don't leave code commented
Collaborator
victor-gonzalez
left a comment
victor-gonzalez
left a comment
There was a problem hiding this comment.
Please, have a look at my comments
Renaming the source file is mandatory before approval. The others can be handled in next iterations
added 2 commits
April 22, 2026 01:16
vkucera
requested changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.