feat(chart): add extra env support#26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
0.1.37to0.1.38.29.14.0/v29.14.0to29.19.0/v29.19.0.node.extraEnvso operators can append arbitrary environment variables to the external node container beyond the chart's preconfigured env vars.Impact
Chart users can now set additional node environment variables through values without needing to fork or patch the StatefulSet template.
Validation
helm lint /private/tmp/abstract-node-chart-test.9mSFAy/abstract-nodehelm template abstract-node /private/tmp/abstract-node-chart-test.9mSFAy/abstract-nodehelm template abstract-node /private/tmp/abstract-node-chart-test.9mSFAy/abstract-node --set node.extraEnv.FOO=bar --set node.extraEnv.NUMERIC=123PR-Codex overview
This PR updates the
abstract-nodeHelm chart by adding support for additional environment variables, updating version numbers, and modifying configuration for the external node.Detailed summary
extraEnvinstatefulset.yamlto allow additional environment variables.tagfromv29.14.0tov29.19.0invalues.yaml.versionfrom0.1.37to0.1.38inChart.yaml.appVersionfrom29.14.0to29.19.0inChart.yaml.