packaging/docs: replace deprecated rpc.batchlimit key#2216
Open
odupontt wants to merge 1 commit into0xPolygon:developfrom
Open
packaging/docs: replace deprecated rpc.batchlimit key#2216odupontt wants to merge 1 commit into0xPolygon:developfrom
odupontt wants to merge 1 commit into0xPolygon:developfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This PR fixes a real configuration correctness issue caused by a key mismatch between runtime config parsing and shipped templates/docs.
internal/cli/server/config.gonow expectsrpc.batch-request-limit, but multiple template files and the CLI example still usedrpc.batchlimit.If operators uncommented the old key, Bor silently ignored it and kept the default batch request limit (
1000), which could lead to unexpected production behavior.What was done:
rpc.batchlimitwithrpc.batch-request-limitin all affected packaging templates.builder/files/config.tomlto use the correct key.docs/cli/example_config.tomlto keep docs/examples aligned with runtime behavior.Changes
Nodes audience
This change applies to all operators who rely on shipped Bor templates/examples.
It is not limited to a subset of nodes.
Checklist
Cross repository changes
Testing
Manual tests
rg -n "rpc\.batchlimit" .rg -n "rpc\.batch-request-limit" builder packaging docsAdditional comments
No runtime code path or default value was changed in this PR; this is a template/docs correctness alignment fix to prevent silent misconfiguration.