Skip to content

check/http: a single error results in down status #161

@parkr

Description

@parkr

I added a Pushover notifier to my checks recently and noticed just how flaky they are. By default I have a check which makes 5 attempts. If just one of the attempts fails (e.g. TLS handshake timeout) then boom the whole site is marked down, even if the other 4 work fine.

Would it be possible to consider a configuration option of allowed failed attempts?

Here's the code which configures at-least-one-error-means-down:

checkup/check/http/http.go

Lines 151 to 157 in cdc8b78

// Check errors (down)
for i := range result.Times {
if result.Times[i].Error != "" {
result.Down = true
return result
}
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions